-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a starter template #526
Conversation
I have no strong opinion here. Less is more IMO, so this looks fine. |
If we have this in plonecli/bobtemplates.plone we should add docs and describe better what it does. |
…ates.plone into erral-starter-subtemplate
I have renamed the template to be The aim of this subtemplate is to be able to initialize a Plone site using an addon, this way, when installed, the addon can set the site title, available langues, or whatever. It's a kind of "policy product configuration", but I have never liked the "policy" name for this :/ |
@erral i mannaged to finally fix the build. folder: /bobtemplate/site_initialization this way it's all clean from the start ;) |
I have renamed everything to site_initialization :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but the changes in setup.py look ood, please explain why we should write the string like this.
The strange strings were removed. |
the test setup, is broken here. I tried to fix it, but so far we still have some linting issues inside the generated addon tests. |
I will try to take care of this during the Conference sprint |
@MrTango I finally removed the additions I made to include Python 3.11 in the test setup and the PR is green. Including Python 3.11 should be a PR on itself if wanted. |
With this starter template we can initialize the Plone site with some sane defaults. This sub-template will be used by cookiecutter-plone-starter
Right now it only sets the site title and configures the default languages.
See collective/cookiecutter-plone-starter#25 for reference.